Add test coverage as 4th Copeland criterion with anti-gaming safeguards#120
Merged
Merged
Conversation
Split filesChanged into nonTestFiles (fewer=better) and testFiles (more=better, capped at 3). Anti-gaming: test files only count when agent also changed production code. Prevents score inflation via empty test files. 4 criteria now: tests passed, convergence, code scope, test coverage. Generated by thinktank Opus (5 agents, 4 pass, all 3 passing had identical anti-gaming logic — strong consensus on the approach). Closes #119 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
effectiveTestFileCount()for testabilityGenerated by thinktank Opus — 5 agents, 4/5 pass. All 3 passing agents independently implemented the same anti-gaming logic (nonTestFiles > 0 check + Math.min cap). Strong consensus.
Change type
Related issue
Closes #119
How to test
Breaking changes
filesChangedWins→nonTestFilesWins+testFilesWins🤖 Generated with thinktank (Opus)